[PATCH 2/2] handle an unspecified return address column

Joel Brobecker brobecker@adacore.com
Tue Nov 26 14:37:00 GMT 2013


> > gdb/ChangeLog:
> > 
> >         PR backtrace/16155:
> >         * dwarf2-frame.c (dwarf2_frame_cache): Remove condition that
> >         sets cache->undefined_retaddr to 1 if there is no column in
> >         the frame info for the return register.
> > 
> > Tested on x86_64-linux, no regression. It also fixes all regressions
> > observed on arm-elf and ppc-elf.
> > 
> > Can you tell me what you think?
> 
> Please start with backing out the original change.

I would gladly do so, but can you explain the rationale behind your
request? Is it to facilitate review of this patch? Or is it because
you think all of the original patch needs to go? I felt that the patch
just overachieved a bit from what it initially set out to do (detect
unspecified return registers), and so I felt it was ok to send a
followup rather than redo it entirely.

-- 
Joel



More information about the Gdb-patches mailing list