[RFA 2/2] Add "undefined-command" error code at end of ^error result...

[Joel Brobecker]

On Tue, Nov 19, 2013 at 11:13:30AM +0000, Pedro Alves wrote:
> On 11/18/2013 05:11 PM, Joel Brobecker wrote:
> 
> > gdb/ChangeLog:
> > 
> >         (from Pedro Alves  <palves@redhat.com>)
> >         (from Joel Brobecker  <brobecker@adacore.com>)
> >         * exceptions.h (enum_errors) <UNKNOWN_COMMAND_ERROR>: New enum.
> >         * mi/mi-parse.c (mi_parse): Thow UNKNOWN_COMMAND_ERROR instead
> 
> "Throw"
> 
> >         of a regular error when the GDB/MI command does not exist.
> >         * mi/mi-main.c (mi_cmd_list_features): Add
> >         "undefined-command-error-code".
> >         (mi_print_exception): Print an "undefined-command"
> >         error code if EXCEPTION.ERROR in UNKNOWN_COMMAND_ERROR.
> 
> s/in/is ?
> 
> >         * NEWS: Add entry documenting the new "code" variable in
> >         "^error" result records.
> > 
> > gdb/doc/ChangeLog:
> > 
> >         * gdb.texinfo (GDB/MI Result Records): Fix the syntax of the
> >         "^error" result record concerning the error message.  Document
> >         the error code that may also be part of that result record.
> >         (GDB/MI Miscellaneous Commands): Document the
> >         "undefined-command-error-code" element in the output of
> >         the "-list-features" GDB/MI command.
> > 
> > gdb/testsuite/ChangeLog:
> > 
> >         * gdb.mi/mi-undefined-cmd.exp: New testcase.
> > 
> > Tested on x86_64-linux.  OK to commit?
> 
> Looks good to me...

Thanks, Pedro! I've made the corrections for the errors you spotted.
And for the UNKNOWN_COMMAND_ERROR vs UNDEFINED_COMMAND_ERROR, I had
already made the changes in the first re-send, for the documentation
fixes.

This patch depends on patch #1,  not logically, but there are conflicts
areas that I'd rather not have to deal with if I don't have to. I am
just hoping for someone to review the patch (hint, hint! :-)). If it
takes too much time, I will put this one in first.

-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-undefined-command-error-code-at-end-of-error-res.patch
Type: text/x-diff
Size: 8875 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20131120/06464ae9/attachment.bin>