[PATCH] Remove unused parameter in remote_check_symbols.

Yao Qi yao@codesourcery.com
Wed May 29 10:04:00 GMT 2013


On 05/28/2013 11:18 PM, Tom Tromey wrote:
> I suppose this code could use the objfile argument if the call to
> remote_check_symbols in remote_start_remote looped over all the
> objfiles.

Tom,
IIUC, there is only one objfile, symfile_objfile, when 
remote_check_symbols is called in remote_start_remote.  After that, when 
a new objfile is loaded each time, remote_check_symbols is called again.

>
> That seems like a minor optimization though.
>
> I noticed that this code doesn't handle the case where an objfile is
> destroyed.  That would seem to potentially leave the remote with an
> invalid address.  But maybe this doesn't matter for some reason?

When an objfile is destroyed (shared lib is unloaded, for example), the 
address becomes unreachable to inferior.  We don't have to worry about 
it, right?

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list