New patch: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd

Svante Signell svante.signell@gmail.com
Mon May 27 16:03:00 GMT 2013


On Mon, 2013-05-27 at 18:30 +0400, Joel Brobecker wrote:

> Clearly lots of errors in the patch I sent. Can you apply the changes
> you suggested, recompile to make sure it at least builds, and post
> again here. Because there is no testing involved, I'd like more people
> to have a chance to review it before it gets checked in.
> 
> Thank you,

Note: Separate patch for another function: find_and_open_solib as
requested.

Attaching a patch and Chengelog entry for the function
nto_find_and_open_solib preceding nto_init_solib_absolute_prefix. There
I did not see any use of the make_cleanup/do_cleanups functions
(assuming open and openp always return). Therefore xfree is used
directly. (Maybe line break of the first xsnprintf statement is not
correctly placed, what does GCS say here?)
-------------- next part --------------
2013-05-27  Svante Signell  <svante.signell@gmail.com>

	* nto-dep.c (nto_find_and_open_solib): Use xstrprintf followed by
	a cleanup instead of alloca to be consistent with function
	(nto_init_solib_absolute_prefix).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: use_xstrprintf.patch
Type: text/x-patch
Size: 1663 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130527/d6240d53/attachment.bin>


More information about the Gdb-patches mailing list