[RFC] msp430 instruction decoder

DJ Delorie dj@redhat.com
Thu May 23 05:48:00 GMT 2013


>  - in msp430_decode_opcode, are the multiple macro calls on the same line on=20
> purpose, or should those get fixed to be one per line ?  for example:
>   ID (dopc_to_id (dopc)); ASX (sreg, as, srxt_bits); ADX (dreg, a, dsxt_bits);=20
> ABW (al_bit, b);

On purpose.  The order of the macros is important, and they typically
correspond to bits in the bit pattern above it.  So the "common"
macros that pull out fields were kept on one line.

Plus, the source would be very white-heavy if you had one tiny macro
on each line ;-)



More information about the Gdb-patches mailing list