[RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]

[Joel Brobecker]

> The checker found two -- the one you fixed in
> ada_make_symbol_completion_list, and also a dangling cleanup in
> old_renaming_is_invisible.  This one seemed hard to fix and so
> in my patch series I just punted on it by marking it with
> the dangling_cleanup attribute.

Do you see something obviously wrong with the attached patch?
I haven't tested it yet, and I am not sure how much I can test it,
given that old-style renamings have been replaced 6 years ago.
I was looking at the option of removing support for them, but
I actually know of some users still using an ancient version
of the compiler but with a new version of the debugger...

-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: old_renaming_is_invisible-cleanup.diff
Type: text/x-diff
Size: 1244 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130520/56c3a4c7/attachment.bin>