[RFC] getc/putc -Wunused-value warnings in source.c

Joel Brobecker brobecker@adacore.com
Thu May 9 06:54:00 GMT 2013


> Joel> One could easily work around the problem by using fgetc instead of
> Joel> getc, as done in this patch.
> 
> I think this approach is fine.
> 
> I wouldn't even bother with the comment about AIX.[...]

Thanks, Tom. I agree with your reasoning, so attached is the patch
I checked in.

gdb/ChangeLog:

        * source.c (forward_search_command): Replace call to getc
        by call to fgetc.
        (reverse_search_command): Likewise.

Tested on x86_64-linux, and checked in.

-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-source.c-Use-fgetc-instead-of-getc.patch
Type: text/x-diff
Size: 2171 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130509/46bfa56e/attachment.bin>


More information about the Gdb-patches mailing list