[RFA] Fix file name matching in expand_symtabs_matching_via_partial

Jan Kratochvil jan.kratochvil@redhat.com
Wed May 8 22:22:00 GMT 2013


On Wed, 08 May 2013 21:40:44 +0200, Doug Evans wrote:
> The test
>   (basenames_may_differ
>    || (*file_matcher) (lbasename (ps->filename), data, 1))
> fails and the code falls through assuming the file name matched.

I agree and your new code with "match" is more clear.


[...]
> +	  if (! match)
             ^^^^
###	  if (!match)

GDB Coding Style.


Sorry,
Jan



More information about the Gdb-patches mailing list