RFC: close-on-exec internal file descriptors

Joel Brobecker brobecker@adacore.com
Tue May 7 06:46:00 GMT 2013


> Sorry Joel.
> I did not even consider this possibility.

No worries at all!

> Could you try the appended?  I can't even build parts of it, so...
> 
> I think it is pretty ugly, since it is a layer on top of the
> kernel-level cloexec flags.  However, that is another discussion, from
> the earlier reviews.

Yeah, hard to see an alternative based on the decisions made.
Seems OK to me.

I tested the patches, and they look good to me, except for the fact
that we were missing the #include of filestuff.h. Attached is patch
that builds and tests fine on x86_64-darwin and ia64-hpux...

-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Do-not-close-pipes-used-to-communicate-with-child-du.patch
Type: text/x-diff
Size: 3701 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130507/2207352d/attachment.bin>


More information about the Gdb-patches mailing list