[patch][python] 4 of 5 - Frame filter testsuite changes

Tom Tromey tromey@redhat.com
Fri Mar 22 19:24:00 GMT 2013


>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> 2013-03-11  Phil Muldoon  <pmuldoon@redhat.com>
Phil> 	* gdb.python/py-framefilter.py: New File.
Phil> 	* gdb.python/py-framefilter-mi.exp: Ditto.
Phil> 	* gdb.python/py-framefilter.c: Ditto.
Phil> 	* gdb.python/py-framefilter-mi.exp: Ditto.
Phil> 	* gdb.python/py-framefilter-mi.c: Ditto,
Phil> 	* gdb.python/py-framefilter-gdb.py.in: Ditto,

The two .c files look the same to me.
It is fine to reuse a .c file in different tests -- what isn't ok is
reusing the same executable file name, but you don't do that.

As we discussed in the other email and on irc, this should have tests
for nested blocks, block-less frames, and completion.

Otherwise this looks good to me.

Tom



More information about the Gdb-patches mailing list