[PATCH v3 12/15] Write tracepoint definition in CTF and read.

Tom Tromey tromey@redhat.com
Tue Mar 12 20:02:00 GMT 2013


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2013-03-08  Yao Qi  <yao@codesourcery.com>
Yao> 	* ctf.c (CTF_EVENT_ID_TP_DEF): New macro.
Yao> 	ctf_write_header): Define event type "tp_def" in metadata.
Yao> 	(ctf_write_uploaded_tp): Write tracepoint definition to CTF.
Yao> 	(SET_ARRAY_FIELD, SET_STRING_FIELD): New macros.
Yao> 	(ctf_read_tp): New.
Yao> 	(ctf_open): Call ctf_read_tp.  Adjust the event id checking.
Yao> 	Call merge_uploaded_tracepoints.

This looks good to me, with one tiny nit:

Yao> +   is about all aspects of a uploaded tracepoint.  Note that the

"an uploaded".

Tom



More information about the Gdb-patches mailing list