New ARI warning Sun Mar 10 02:06:07 UTC 2013 in -D 2013-03-10-gmt

Pedro Alves palves@redhat.com
Mon Mar 11 12:09:00 GMT 2013


On 03/11/2013 12:03 PM, Abid, Hafiz wrote:
> On 10/03/13 02:06:07, GDB Administrator wrote:
>> 623a624
>> > gdb/remote.c:11047: code: OP eol: Do not use &&, or || at the end of a line
>> gdb/remote.c:11047:  if (remote_protocol_packets[PACKET_QTBuffer_size].support !=
>>
> 
> Hi All,
> I noticed the above ARI warning. I will apply the following if there are no objections. I think it is obvious.

Yes, thanks.  Please go ahead.

> 
> Regards,
> Abid
> 
> gdb/ChangeLog:
> 
>     * remote.c (remote_set_trace_buffer_size): Move != operator
>     to the start of next line to fix an ARI warning.
> 
> 
> diff --git a/gdb/remote.c b/gdb/remote.c
> index 8fc6b85..c4824e9 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -11056,8 +11056,8 @@ remote_get_min_fast_tracepoint_insn_len (void)
>  static void
>  remote_set_trace_buffer_size (LONGEST val)
>  {
> -  if (remote_protocol_packets[PACKET_QTBuffer_size].support !=
> -      PACKET_DISABLE)
> +  if (remote_protocol_packets[PACKET_QTBuffer_size].support
> +      != PACKET_DISABLE)
>      {
>        struct remote_state *rs = get_remote_state ();
>        char *buf = rs->buf;


-- 
Pedro Alves



More information about the Gdb-patches mailing list