[patch v10 20/21] testsuite, gdb.btrace: add btrace tests

[Jan Kratochvil]

On Fri, 08 Mar 2013 14:27:44 +0100, Metzger, Markus T wrote:
> > > +  /* loop is declared in x86-instruction_history.S */
> > 
> > /* loop is defined in 'instruction_history.S'.  */
> 
> I got the feedback in a review of the earlier btrace tests that x86-specific
> assembly files need to be prefixed with either x86-, ia32-, or amd64- depending
> on the architecture for which they are intended.

OK but the file is already renamed in the patch.  BTW the ChangeLog is not
updated for the rename:
        * gdb.btrace/x86-instruction_history.S: New file.
->
        * gdb.btrace/instruction_history.S: New file.

I won't argue against another maintainer opinion, follow either way you
prefer.  Just the code comment should contain the name actually used in the
patch.


Thanks,
Jan