[commit] Adapt sim to new version number & date locations.

Tom Tromey tromey@redhat.com
Tue Jun 25 15:28:00 GMT 2013


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> The common and ppc parts were easy to fix, by just doing a reduced
Joel> version of what we do for GDB and GDBserver. Moxie, on the other
Joel> hand, needs the version info for different reasons, and I prefered
Joel> not touching it.

I looked at this a bit.

Right now the code there is a bit broken.  If you update your source
tree, rebuild, and reinstall, then you can end up in a situation where
the moxie sim reads an outdated moxie-gdb.dtb file.

This can happen due to missing dependencies: the version number is built
into the sim via a -D option, but interp.o doesn't depend on the version
file.

I think that since we don't generally support versioned installs in gdb,
it is simplest to just drop the version number here.  This fixes the bug
and also avoids using gdb's version.in.

Ok?

Tom

2013-06-25  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (dtbdir): Don't use gdb's version.in.

diff --git a/sim/moxie/Makefile.in b/sim/moxie/Makefile.in
index 884d277..3be637b 100644
--- a/sim/moxie/Makefile.in
+++ b/sim/moxie/Makefile.in
@@ -17,7 +17,7 @@
 
 ## COMMON_PRE_CONFIG_FRAG
 
-dtbdir = @datadir@/gdb-`sed q ${srcdir}/../../gdb/version.in`/dtb
+dtbdir = @datadir@/gdb/dtb
 
 SIM_OBJS = interp.o sim-load.o sim-io.o sim-config.o sim-utils.o	\
 sim-options.o sim-module.o sim-core.o sim-endian.o sim-trace.o 	\



More information about the Gdb-patches mailing list