[PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'

Doug Evans dje@google.com
Mon Jun 24 19:04:00 GMT 2013


On Mon, Jun 24, 2013 at 11:44 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 24 Jun 2013 11:35:31 -0700
>> From: Doug Evans <dje@google.com>
>> Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
>>
>> > diff -u -p -r1.236 top.c
>> > --- gdb/top.c   30 May 2013 17:27:44 -0000      1.236
>> > +++ gdb/top.c   22 Jun 2013 11:30:47 -0000
>> > @@ -1252,6 +1252,9 @@ This GDB was configured as follows:\n\
>> >               --without-babeltrace\n\
>> >  "));
>> >  #endif
>> > +    fprintf_filtered (stream, _("\n\
>> > + (\"Relocatable\" means directory can be moved with the GDB installation tree.)\n\
>> > +"));
>> >  }
>>
>> If you want to print something here, then I think you need to take
>> into account whether "relocatable" is printed at all.
>
> I don't think it's a real danger.  One must invest a non-trivial
> effort to have GDB configured without a single relocatable directory.

Ok, How about:

+    /* We assume "relocatable" will be printed at least once, thus we always
+       print this text.  It's a reasonably safe assumption for now.  */
+    fprintf_filtered (stream, _("\n\
+ (\"Relocatable\" means the directory can be moved with the GDB installation"
"tree and GDB will still find it.)\n\"
+"));

[N.B. I didn't verify 80-column-ness, leaving that to you if you like
the wording.]

>> How about just a sentence or two in the manual near the description of
>> --configuration (or some such).
>
> I tried that, but found no good place to say that.  Just saying
> something where --configuration is described will get this lost in the
> humongous manual, and users will not necessarily know where to look.

"relocatable" doesn't appear that many times in the manual.
"(relocatable)" doesn't currently appear at all.
If a user can't find it I'm not worried about claims it's the manual's fault.

Having this text is not important to me though, so feel free to drop it.



More information about the Gdb-patches mailing list