[PATCH 2/3] Move mips hardware watchpoint stuff to common/

Joel Brobecker brobecker@adacore.com
Fri Jun 21 15:55:00 GMT 2013


>  FWIW and IMHO.

What you say makes sense to me, and I would agree to an update.
I do think that we should try to standardize to a minimum number
of lengths. For new, we have two kinds of "text":
  - Documentation/comments
  - Code

I'd agree to 78 or 79 for code, and I've often found that the extra
length would allow a statement to fit on fewer lines, looking and
reading better. I would add that I've always felt that 70 was a soft
limit, and that people should feel free to extend when needed.

For documentation, I would have stayed with 70, except that ChangeLog
files can be considered code. I'm wondering if we could try 74 instead.

FWIW and IMHO as well :). The problem with those types of discussions
that people tend to discuss them a lot, but then it's hard to actually
make any decision. I'll say I'm flexible - and actually have been
already wrt past code reviews. I think of this "rule" more as a
guideline, rather than a hard rule.

-- 
Joel



More information about the Gdb-patches mailing list