[RFA 3/4] Explicit locations

[Keith Seitz]

On 03/21/2013 04:58 PM, Keith Seitz wrote:
> This purpose of this patch is to add functionality (and tests) to the
> CLI and MI for explicit locations.

This is a rebased version of this patch. Unlike previous patches, this 
one has changed a little bit from the previous (unreviewed) version: It 
now contains a (very primitive) explicit location completer.

Keith

ChangeLog
2013-06-20  Keith Seitz  <keiths@redhat.com>

	* breakpoint.c (strace_command): Update to handle non-linespec
	locations.
	* completer.c: Include breakopint.h.
	(enum match_type): New enum.
	(location_completer): Rename to ...
	(linespec_completer): ... this.
	(collect_explicit_location_matches): New function.
	(explicit_location_completer): New function.
	(location_completer): "New" function; handle linespec
	and explicit location completions.
	(complete_line_internal): Remove all location completer-specific
	handling.
	* linespec.c (linespec_parse_line_offset): Export.
	If the first character of the input is not a digit,
	throw an error.
	(explicit_location_lex_one): New function.
	(string_to_explicit_location): New function.
	(string_to_event_location): Handle explicit locations.
	* linespec.h (string_to_explicit_location): Declare.
	(linespec_parse_line_offset): Declare.
	(location_completer): Declare.
	* mi/mi-cmd-break.c (mi_cmd_break_insert): Handle explicit
	locations.
	* probe.c (parse_probes): Handle explicit locations.

testsuite/ChangeLog
2013-06-20  Keith Seitz  <keiths@redhat.com>

	* gdb.base/save-bp.exp: Add tests for address locations
	and explicit locations, pending and not-pending, with and
	without conditions, including resolved pending breakpoints.
	* gdb.linespec/3explicit.c: New file.
	* gdb.linespec/cpexplicit.cc: New file.
	* gdb.linespec/cpexplicit.exp: New file.
	* gdb.linespec/explicit.c: New file.
	* gdb.linespec/explicit.exp: New file.
	* gdb.linespec/explicit2.c: New file.
	* gdb.linespec/ls-errs.exp: Add explicit location tests.
	* gdb.mi/mi-break.exp: Likewise.
	* lib/mi-support.exp (mi_create_breakpoint): Add support
	for conditions.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: explicit-user.patch
Type: text/x-patch
Size: 66407 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130620/0fbee80f/attachment.bin>