[OB PATCH] Remove parameter 'lsal' of create_breakpoints_sal_default

Yao Qi yao@codesourcery.com
Wed Jun 19 06:39:00 GMT 2013


Hi,
Function create_breakpoints_sal_default simply calls
create_breakpoints_sal where parameter 'lsal' is not used.  This patch
is to remove parameter 'lsal'.  It is obvious and I'll commit it
tomorrow.

Even the parameter 'lsal' of the member 'create_breakpoints_sal' in
struct breakpoint_ops could be removed after some tweaks in
strace_marker_create_breakpoints_sal, in which 'lsal' is used, but it
can be retrieved from another parameter 'canonical'.  This can be
fixed by another patch.

gdb:

2013-06-19  Yao Qi  <yao@codesourcery.com>

	* breakpoint.c (create_breakpoints_sal_default): Remove
	parameter 'lsal'.  Update declaration.
	(bkpt_create_breakpoints_sal): Caller update.
	(tracepoint_create_breakpoints_sal): Likewise.
---
 gdb/breakpoint.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index b2ac251..b0184ad 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -119,7 +119,6 @@ static void create_sals_from_address_default (char **,
 
 static void create_breakpoints_sal_default (struct gdbarch *,
 					    struct linespec_result *,
-					    struct linespec_sals *,
 					    char *, char *, enum bptype,
 					    enum bpdisp, int, int,
 					    int,
@@ -12936,7 +12935,7 @@ bkpt_create_breakpoints_sal (struct gdbarch *gdbarch,
 			     int from_tty, int enabled,
 			     int internal, unsigned flags)
 {
-  create_breakpoints_sal_default (gdbarch, canonical, lsal,
+  create_breakpoints_sal_default (gdbarch, canonical,
 				  cond_string, extra_string,
 				  type_wanted,
 				  disposition, thread, task,
@@ -13274,7 +13273,7 @@ tracepoint_create_breakpoints_sal (struct gdbarch *gdbarch,
 				   int from_tty, int enabled,
 				   int internal, unsigned flags)
 {
-  create_breakpoints_sal_default (gdbarch, canonical, lsal,
+  create_breakpoints_sal_default (gdbarch, canonical,
 				  cond_string, extra_string,
 				  type_wanted,
 				  disposition, thread, task,
@@ -14110,7 +14109,6 @@ create_sals_from_address_default (char **arg,
 static void
 create_breakpoints_sal_default (struct gdbarch *gdbarch,
 				struct linespec_result *canonical,
-				struct linespec_sals *lsal,
 				char *cond_string,
 				char *extra_string,
 				enum bptype type_wanted,
-- 
1.7.7.6



More information about the Gdb-patches mailing list