[commit/windows] Add thread ID in SuspendThread error warning message.

Joel Brobecker brobecker@adacore.com
Tue Jun 11 11:07:00 GMT 2013


> On 06/11/2013 11:21 AM, Joel Brobecker wrote:
> >  		    DWORD err = GetLastError ();
> > -		    warning (_("SuspendThread failed. (winerr %u)"),
> > -			     (unsigned) err);
> > +		    warning (_("SuspendThread (tid=0x%x) failed."
> > +			       " (winerr %d)"),
> 
> This reverted part of a previous change (winerr %u -> winerr %d).

Gasp!!! Thanks for spotting that - I did do a word-by-word diff
with git, and yet missed it :-(.

> > +			     (unsigned) id, (unsigned) err);
> >  		    return NULL;

Fixed thusly. Re-checked with word-by-word diff, and hopefully
OK, this time.

gdb/ChangeLog:

        * windows-nat.c (thread_rec): Revert format used to print
        error code returned by SuspendThread from %d back to %u.

Thanks again,
-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: windows-nat-thread-rec-winerr-format.diff
Type: text/x-diff
Size: 1480 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130611/69fd6733/attachment.bin>


More information about the Gdb-patches mailing list