Fwd: [PATCH] fix Bug 11568 - delete thread-specific breakpoint on the thread exit

Tom Tromey tromey@redhat.com
Tue Jul 23 18:24:00 GMT 2013


>>>>> ">" == Waqas Jamil <waqas.jamil47@gmail.com> writes:

>> Now is it ok?
>> 2013-07-22  Muhammad  Waqas  <waqas.jamil47@gmail.com>

>>              * breakpoint.c (breakpoint_auto_delete): remove breakpoints
>>              remove thread specified breakpoints

The body of the entry should be indented with tabs.
"remove" should have a capital "r" and there should be a "." at the end.

>> --- mygdb/gdb-7.6/gdb/breakpoint.c      2013-07-23 08:30:56.231681932 +0500
>> +++ /home/waqas/Downloads/gdb/gdb-7.6/gdb/breakpoint.c  2013-04-25

Your patch is reversed.

Also, this needs a test case.

Finally, do you have a copyright assignment in place?
If not, contact me off-list to get started.

Tom



More information about the Gdb-patches mailing list