[PATCH] Revised display-linkage-name

[Michael Eager]

On 07/22/13 10:48, Keith Seitz wrote:
> On 07/17/2013 11:51 AM, Michael Eager wrote:

>>   void
>> +annotate_linkage_name (void)
>> +{
>> +  if (annotation_level == 2)
>> +    printf_filtered (("\n\032\032linkage_name\n"));
>> +}
>> +
>
> This is still missing a (trivial) comment. [IIRC, we require comments for *all* functions, even if
> they are pretty trivial.]

The Changelog contains
       * annotate.c (annotate_linkage_name): New.
       * annotate.h (annotate_linkage_name): New decl.

Is something else needed?

>
> I think with these minor things fixed, a global maintainer should give a final review (and approval).

I believe that the attached updated patch addresses all of your comments.


-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-GDB-display-linkage-name-command.patch
Type: text/x-patch
Size: 23596 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130722/b8d48a94/attachment.bin>