[PATCH] Revised display-linkage-name

[Michael Eager]

On 07/12/13 14:17, Michael Eager wrote:
> On 07/11/13 16:28, Keith Seitz wrote:
>> On 07/10/2013 09:17 AM, Michael Eager wrote:
>>> Can someone review and approve this patch?
>>
>> Tom's been a little busy of late, so I thought I would try to help out here a little. You'll be one
>> step closer to approval!
>>
>> Your patches no longer apply cleanly to HEAD, so I fixed them up to play with them. I'll be
>> commenting on this version.
>>
>
> ...
>
>> Keith
>
> Thanks.  I'll look at your comments and submit an update.
>
> I'll eliminate the whitespace changes; I find them annoying as well.
> I'll allow passing a NULL for the linkname where the result is
> not used.  I'm not sure how the default got set to "on"; that was
> not intentional, and yes, it causes a lot of noise regressions.
> "Prepend" appears to be listed in some dictionaries as a synonym
> for "prefix," but it may sound like jargon; I'll change it.
>
> I'll look at the suggestions about the test suite.  I've reasonable
> experience with tcl/expect, but tcl always seems to turn into a tar pit.
>
> If you have a different term for "linkage name" I'd be happy to
> hear it.  The only use of this that I was able to find is in the
> DWARF Standard.  Or I can add a definition to the docs to clarify.

I believe I have addressed your comments, as well as Eli's previous
notes about the docs.  I didn't merge the tests cases into a single proc.

BTW, "prepend" appears in several places in the docs.  I replaced it this
patch with prefix.  If there is a concern that "prepend" sounds like jargon,
then the other uses should be changed as well.



gdb/
2013-07-17  Michael Eager <eager@eagercon.com>

       * NEWS: Announcement.
       * ada-lang.c: Update calls to find_frame_funname (pass NULL for linkname).
       * disasm.c: Likewise.
       * python/py-frame.c: Likewise.
       * annotate.c (annotate_linkage_name): New.
       * annotate.h (annotate_linkage_name): New decl.
       * breakpoint.c (print_breakpoint_location): Print linkage name.
       * defs.h (build_address_symbolic): Add linkname arg.
       * printcmd.c (print_address_symbolic): Print linkage name.
       (build_address_symbolic): Return linkage name.
       * annotate.c (annotate_linkage_name): New.
       * annotate.h (annotate_linkage_name): Declare.
       * stack.c (find_frame_funname): Return linkage name.
       (print_frame): Print linkage name.
       * stack.h (find_frame_funname): Update declaration.
       * top.c (display_linkage_name, display_linkage_name_len): New.
       (show_display_linkage_name, show_display_linkage_name_len): New cmds.
       * top.h (display_linkage_name, display_linkage_name_len): Declare.

gdb/doc
2013-07-17  Michael Eager <eager@eagercon.com>

       * gdb.texinfo: Add description.

gdb/testsuite
2013-07-17  Michael Eager <eager@eagercon.com>

       * gdb.cp/display-linkage-name.exp: New.
       * gdb.cp/display-linkage-name.cc: New.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-GDB-display-linkage-name-command.patch
Type: text/x-patch
Size: 23818 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130717/3b332921/attachment.bin>