Patch contribution

[Sergio Durigan Junior]

On Friday, July 12 2013, Bill Neubauer wrote:

> This patch adds functionality to the Mach-O reader to be aware of the
> .debug_gdb_scripts section produced in Mac OS X binaries by the Go
> toolchain. This issue is documented in more detail at
> https://code.google.com/p/go/issues/detail?id=4194

Thanks for the patch.  Since it touches BFD code, it should be sent to
<binutils@sourceware.org>.  There are also some formatting nits.  The
first one is the subject of the e-mail: please try to be more specific.

> 2013-07-11 Bill Neubauer <wcn@google.com>

This line should be:

2013-07-11  Bill Neubauer  <wcn@google.com>

I.e., two spaces between the date and the name, and two spaces between
the name and the e-mail address.

> 			  * mach-o.c (debug_gdb_scripts): Added.

Too many TABs.  There should be only one.  Also, the name inside the
parenthesis should be the name of the struct you're adding the field
to.  An entry like:

	* mach-o.c (mach_o_section_name_xlat dw): Add entry for
	.debug_gdb_scripts.

should be OK.

> --- ./mach-o.c	2013-07-11 07:16:39.000000000 -0700
> +++ /tmp/gdb-7.6/bfd/mach-o.c	2013-07-11 06:56:20.000000000 -0700
> @@ -197,6 +197,9 @@ static const mach_o_section_name_xlat dw
>      {	".debug_macro",			"__debug_macro",
>  	SEC_DEBUGGING,			BFD_MACH_O_S_REGULAR,
>  	BFD_MACH_O_S_ATTR_DEBUG,	0},
> +    {	".debug_gdb_scripts",		"__debug_gdb_scri",
> +	SEC_DEBUGGING,			BFD_MACH_O_S_REGULAR,
> +	BFD_MACH_O_S_ATTR_DEBUG,	0},
>      { NULL, NULL, 0, 0, 0, 0}
>    }

Could you please resubmit the patch with the proposed modifications to
the binutils mailing list?

Thanks,

-- 
Sergio