Updated patch for Bug 13217 - thread apply all detach throws a SEGFAULT

ali_anwar ali_anwar@codesourcery.com
Thu Jul 11 12:30:00 GMT 2013


On 07/10/2013 10:55 PM, Tom Tromey wrote:
>>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:
>
>
> This installs the cleanups at the wrong point.
> They must be installed before any potential exception is thrown.
>
> That is, the xfree cleanup ought to be created just after initialization;
> and the refcount cleanup ought to be created after the refcounts are
> incremented.
>
> Also, make_cleanup_thread_refcount is misnamed.
> By convention, a "make_cleanup_" function creates a new cleanup.
> The function that does the work of cleaning up is given a different name.
>

Thanks for the Review.

Please find attached updated patch.

-Ali

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PR13217.patch
Type: text/x-patch
Size: 4334 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130711/663a469a/attachment.bin>


More information about the Gdb-patches mailing list