[PATCH] wp-replication: Fix test case loop

Andreas Arnez arnez@linux.vnet.ibm.com
Fri Jul 5 16:10:00 GMT 2013


When executing wp-replication.exp on S/390, the loop that counts the
number of available hardware watchpoints does not terminate properly,
because *all* "watch" commands yield "hardware watchpoints".

Since the C source code is not prepared for more than NR_THREADS
hardware watchpoints anyhow, I suggest to add the appropriate exit
condition to the loop.


2013-07-05  Andreas Arnez  <arnez@linux.vnet.ibm.com>

	* gdb.threads/wp-replication.exp: Stop counting available hardware
	watchpoints after NR_THREADS iterations.

diff --git a/gdb/testsuite/gdb.threads/wp-replication.exp b/gdb/testsuite/gdb.threads/wp-replication.exp
index 8927a43..af3594d 100644
--- a/gdb/testsuite/gdb.threads/wp-replication.exp
+++ b/gdb/testsuite/gdb.threads/wp-replication.exp
@@ -81,6 +81,10 @@ while { $done == 0 } {
   gdb_test_multiple "continue" "watchpoint created successfully" {
     -re ".*Breakpoint 2, empty_cycle \\(\\).*$gdb_prompt $" {
       incr hwatch_count
+      if { $hwatch_count == $NR_THREADS } {
+	set done 1
+	break
+      }
     }
     -re ".*Could not insert hardware watchpoint.*$gdb_prompt $" {
       set done 1



More information about the Gdb-patches mailing list