[PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes

Yao Qi yao@codesourcery.com
Wed Jul 3 10:55:00 GMT 2013


On 07/03/2013 04:41 PM, Hui Zhu wrote:
> @@ -68,7 +68,7 @@ proc mi_continue_dprintf {args} {
>   	mi_run_cmd
>   	set msg "mi 1st dprintf"
>   	gdb_expect {
> -            -re ".*At foo entry.*arg=1234, g=1234" {
> +            -re ".*foobarbazqux.*At foo entry.*arg=1234, g=1234" {

It is good if we match double quotes before and after foobarbazqux, and 
get rid of ".*" between "foobarbazqux" and "At foo entry", in order to 
get the test more restrictive.  Something like

   ".*\\\\\"foobarbazqux\\\\\" At foo entry.*arg=1234, g=1234"

I have no other comments then.

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list