[PATCH v2 3/4] gdbserver, win32: fix some function typedefs

Mircea Gherzan mircea.gherzan@intel.com
Tue Jul 2 12:58:00 GMT 2013


On 01.07.2013 19:47, Pedro Alves wrote:
> Not sure I'd call this a "fix", vs "our compiler works like
> MSFT's here".  Is gcc wrong in allowing the attribute outside
> the parens?

WINAPI is __stdcall and thus "Microsoft specific". According to the 
documentation [1], the modifier should be inside the parens. 
Furthermore, this is consistent with the rest of the typedefs in the file.

> On 07/01/2013 06:24 PM, Mircea Gherzan wrote:
>> 2013-05-25  Mircea Gherzan  <mircea.gherzan@intel.com>
>>
>> gdbserver/
>> 	* win32-low.c (winapi_DebugActiveProcessStop): Move the WINAPI
>> 	attribute inside the parentheses.
>> 	(winapi_DebugSetProcessKillOnExit): Ditto.
>> 	(winapi_DebugBreakProcess): Ditto.
>> 	(winapi_GenerateConsoleCtrlEvent): Ditto.
>
> OK.

Thanks, applied.

[1] http://msdn.microsoft.com/en-us/library/zxk0tw93.aspx

-- 
Mircea Gherzan

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052



More information about the Gdb-patches mailing list