[PATCH 11/16] move some statics from remote_read_qxfer into struct remote_state

Tom Tromey tromey@redhat.com
Mon Jul 1 18:06:00 GMT 2013


>> This moves a few static variables out of remote_read_qxfer and into
>> remote_state.  It is unclear to me if this data can ever be required
>> to be kept around across a potential target switch, but it is
>> definitely safe to move it into the remote state object.

Pedro> Hmm, are we still unclear about it?  It seems to me that if we
Pedro> dropped the data, we'd always be able to re-fetch it, though obviously
Pedro> we'd lose on the optimization.  It definitely seems to me that
Pedro> putting it in the remote state object is the correct choice.
Pedro> Maybe you're seeing something I'm not though.

Nope, I just neglected to update the note.
I've dropped everything after the first sentence.

Tom



More information about the Gdb-patches mailing list