[patch] testsuite build regression on CentOS-5 [Re: [PATCH 1/7] test suite update - gdb.base/[ab]]

[Jan Kratochvil]

On Wed, 19 Jun 2013 23:03:35 +0200, Tom Tromey wrote:
> --- a/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp
> +++ b/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp
[...]
>  set additional_flags {-ffunction-sections -Wl,--gc-sections}
> -if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
> -	   [list debug c++ additional_flags=$additional_flags]] != "" } {
> -    untested $srcfile
> +if {[prepare_for_testing $testfile.exp $testfile $srcfile \
> +	 [list debug c++ additional_flags=$additional_flags]]} {
> +    untested $testfile.exp
>      return -1
>  }

 Running gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp ...
-PASS: gdb.base/break-on-linker-gcd-function.exp: b 24
+gdb compile failed, g++: --gc-sections: linker input file unused because linking not done
+UNTESTED: gdb.base/break-on-linker-gcd-function.exp: break-on-linker-gcd-function.exp
+UNTESTED: gdb.base/break-on-linker-gcd-function.exp: break-on-linker-gcd-function.exp

Retested it still FAILs with the unfixed GDB.

I will check it in.


Jan


gdb/testsuite/
2013-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/break-on-linker-gcd-function.exp: Replace
	prepare_for_testing by build_executable_from_specs and clean_restart.

diff --git a/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp b/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp
index 7a4ef83..f9b844f 100644
--- a/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp
+++ b/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp
@@ -32,12 +32,15 @@ if [get_compiler_info "c++"] {
 }
 
 set additional_flags {-ffunction-sections -Wl,--gc-sections}
-if {[prepare_for_testing $testfile.exp $testfile $srcfile \
-	 [list debug c++ additional_flags=$additional_flags]]} {
+if {[build_executable_from_specs $testfile.exp $testfile \
+       {c++ additional_flags=-Wl,--gc-sections} \
+       $srcfile {debug c++ additional_flags=-ffunction-sections}]} {
     untested $testfile.exp
     return -1
 }
 
+clean_restart $testfile
+
 # Single hex digit
 set xd {[0-9a-f]}