[patchv2 6/11] New option 'set filename-display'

Doug Evans dje@google.com
Tue Jan 29 21:35:00 GMT 2013


Jan Kratochvil writes:
 > +/* See commentary in source.h.  */
 > +
 > +const char *
 > +symtab_to_filename (struct symtab *symtab)
 > +{
 > +  if (filename_display_string == filename_display_basename)
 > +    return lbasename (symtab->filename);
 > +  else if (filename_display_string == filename_display_absolute)
 > +    return symtab_to_fullname (symtab);
 > +  else if (filename_display_string == filename_display_relative)
 > +    return symtab->filename;
 > +  else
 > +    internal_error (__FILE__, __LINE__, _("invalid filename_display_string"));
 > +}

nit:
IWBN if this function were named symtab_to_filename_for_display or symtab_to_display_filename or some such.



More information about the Gdb-patches mailing list