[patch 8/9] Fix .gdb_index for real and absolute filenames

Jan Kratochvil jan.kratochvil@redhat.com
Fri Jan 25 14:51:00 GMT 2013


On Wed, 23 Jan 2013 22:34:52 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> +		char *symtab_real;
> Jan> +
> Jan> +		symtab_real = gdb_realpath (symtab_to_fullname (real_symtab));
> Jan> +		if (file_matches (symtab_real, files, nfiles))
> Jan> +		  match = 1;
> Jan> +		xfree (symtab_real);
> 
> IIUC the realpath is cached for partial symtabs but not full symtabs.
> If so, why the disparity?

There wasn't clear to me the xfullpath vs. gdb_realpath difference as the
current code was already buggy regarding proper handling of the xfullpath vs.
gdb_realpath names.

As Joel has cleared it out now and xfullpath can be dropped the separate
realnames no longer have to be kept, as symtab_to_fullname will use
gdb_realpath and the symtab_to_fullname result is already cached.


Thanks,
Jan



More information about the Gdb-patches mailing list