[FYI] Adding myself to MAINTAINERS(Commit After Approval)
David Blaikie
dblaikie@gmail.com
Fri Jan 18 21:44:00 GMT 2013
On Fri, Jan 18, 2013 at 1:16 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Friday, January 18 2013, David Blaikie wrote:
>
>> RCS file: /cvs/src/src/gdb/ChangeLog,v
>> retrieving revision 1.15036
>> diff -r1.15036 ChangeLog
>> 0a1,3
>>> 2012-12-12 David Blaikie <dblaikie@gmail.com>
>>>
>>> * MAINTAINERS (Write After Approval): Add "David Blaikie".
>
> Hi David,
>
> The date is wrong, and the lines in the ChangeLog file shall be indented
> using TABs, not spaces. You should also add a blank line between your
> entry and the last one.
Sorry - amazing how many mistakes I managed to pack into such a small
change. (little rushed since I realized I'd actually committed a my
label.c patch before updating MAINTAINERS)
> Please fix those errors (there's no need to create a new ChangeLog entry
> for this fix).
Committed in 1.15038 of gdb/ChangeLog. Thanks for the review/catches.
- David
More information about the Gdb-patches
mailing list