[PATCH] Don't check PST is NULL in read_symtab

Tom Tromey tromey@redhat.com
Fri Jan 11 15:06:00 GMT 2013


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> On 01/11/2013 10:34 PM, Tom Tromey wrote:
Joel> If PST must not be NULL, I think that it should be documented in
Joel> psympriv.h. I am also wondering whether an assertion would be
Joel> useful or not; maybe not, just thinking out loud.
>> 
Joel> Tom and Doug are more involved in this area, so they'll probably
Joel> have a more definitive answer.
>> 
>> An assert would be fine by me.

Yao> An assert that PST is not NULL at the beginning of these functions
Yao> dbx_psymtab_to_symtab_1, dwarf2_psymtab_to_symtab,
Yao> mdebug_psymtab_to_symtab, and xcoff_psymtab_to_symtab_1?

Sure.  Though I am ok with just a comment as well.

Tom



More information about the Gdb-patches mailing list