[PATCH] $a0 stored as a DSP register on mips64
Maciej W. Rozycki
macro@codesourcery.com
Mon Jan 7 15:57:00 GMT 2013
Lei, Tom --
> >> Register $a0 on mips64 is now stored as a DSP register if dspacc == -1,
> >> as the regno 4 lies between dspacc and dspacc+6. This causes $a0 can't
> >> be correctly set with PTRACE_SETREGS. We should not check regno against
> >> DSP registers if HAVE_DSP is not set, just like what we did in
> >> mips64_linux_regsets_fetch_registers.
>
> It seems pretty reasonable to me.
> Your change makes store_registers parallel fetch_registers.
>
> >> 2012-12-10 Lei Liu <lei.liu2@windriver.com>
>
> >> * mips-linux-nat.c (mips64_linux_regsets_store_registers):
> >> Don't check DSP register number if HAVE_DSP is not set.
>
> This is ok if you don't hear any objections by next week.
> Thanks.
This is obviously correct and the original intent. Apologies for the
oversight and thanks for catching it and reviewing the fix.
Maciej
More information about the Gdb-patches
mailing list