[RFC/commit 3/3] Delete unused variable in lynx_resume

Joel Brobecker brobecker@adacore.com
Mon Jan 7 11:51:00 GMT 2013


> Error handling in gdbserver is poor.  The Windows ports
> ignore errors (I think errors there would be very rare).
> The Linux ports do error out, see bottom of linux_resume_one_lwp.

Thanks for the tip :). Attached are the two patches I committed.
One removes the unused variable. The other applies the same
treatment as in linux_resume_one_lwp.

gdb/gdbserver/ChangeLog:

        * lynx-low.c (lynx_resume): Delete variable ret.

        * lynx-low.c (lynx_resume): Call perror_with_name if lynx_ptrace
        sets errno.

Tested on ppc-lynx178, with no regressions. Applied.

Thank you,
-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Delete-unused-variable-in-lynx_resume.patch
Type: text/x-diff
Size: 1441 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130107/09b5cebe/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-ptrace-error-handling-in-lynx_resume.patch
Type: text/x-diff
Size: 1421 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20130107/09b5cebe/attachment-0001.bin>


More information about the Gdb-patches mailing list