[Patch] Get trace file name when using 'target tfile'

Pedro Alves palves@redhat.com
Thu Feb 14 15:57:00 GMT 2013


On 02/14/2013 03:49 PM, Abid, Hafiz wrote:

> Thanks everybody for review. The updated patch is attached. The changes from the previous version are.
> 
> 1. Renamed "from_file" field to "filename". Use explicit NULL(or non-NULL) check against it.
> 2. Added a test case for -trace-struct command.
> 3. Added NEWS entry.
> 
> How does it look?


Thanks.  The code bits looks good to me.

Eli should review the new NEWS bit.

>     * remote.c (remote_get_trace_status): Initialize "filename"
>     field with NULL instead    of 0.

                             ^^^^

Something weird with spaces here.

-- 
Pedro Alves



More information about the Gdb-patches mailing list