[RFC/TileGX 5/6]show registers in columns
Pedro Alves
palves@redhat.com
Fri Feb 8 21:09:00 GMT 2013
On 02/08/2013 07:09 PM, Joel Brobecker wrote:
>>>> + else
>>>> + {
>>>> + fprintf_filtered (file, "0x");
>>>> + for (k = 0; k < tilegx_reg_size; k++)
>>>> + {
>>>> + int idx;
>>>> + if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG)
>>>> + idx = k;
>>>> + else
>>>> + idx = tilegx_reg_size - 1 - k;
>>>> + fprintf_filtered (file, "%02x", (unsigned char) buffer[idx]);
>
> I do not think that this is the right way of printing the register
> value, by doing all the work yourself. I am not completely sure
> what the best solution would be, though. The other Global Maintainers
> may have a more definitive answer, but perhaps plongest (value_as_long
> (register_value)). My suggestion is a little iffy because it assumes
> for instance that all register values are signed / or unsigned.
Usually you'd use val_print. How about just exporting and
calling default_print_one_register_info? You get consistency
with other archs for free, and unavailable values handled too.
--
Pedro Alves
More information about the Gdb-patches
mailing list