[PATCH] gdbserver aarch64 fix the clamping of HW break point and watchpoint counts.

Pedro Alves palves@redhat.com
Thu Feb 7 16:14:00 GMT 2013


On 02/07/2013 03:51 PM, Marcus Shawcroft wrote:
> This issue came to light in the recent review of aarch64-linux-nat, and also needs resolving in GDBserver.
> 
> OK?

OK.

> 
> /Marcus
> 
> 2013-02-07  Marcus Shawcroft  <marcus.shawcroft@arm.com>
> 
>        * linux-aarch64-low.c (aarch64_arch_setup): Fix clamping of
>        aarch64_num_wp_regs and aarch64_num_bp_regs.

Minor, minor nit: "Fix" is a "why" (which in general may end up wrong in
retrospect), while change log entries record the "what".  This would
be more in accordance:

        * linux-aarch64-low.c (aarch64_arch_setup): Clamp
	aarch64_num_wp_regs and aarch64_num_bp_regs to
	AARCH64_HWP_MAX_NUM and AARCH64_HBP_MAX_NUM respectively.

Sorry for being pedant.

-- 
Pedro Alves



More information about the Gdb-patches mailing list