[patch] Fix gdb.fortran/common-block.exp crash in PIE mode

Jan Kratochvil jan.kratochvil@redhat.com
Tue Feb 5 21:14:00 GMT 2013


On Mon, 21 Jan 2013 17:12:49 +0100, Tom Tromey wrote:
> Perhaps the various symbol-value accessors like SYMBOL_VALUE_ADDRESS
> should make assertions about the address class.  This is what GCC does
> in its tree accessors.
> 
> Like
> 
> #define SYMBOL_VALUE_COMMON_BLOCK(symbol) \
>   ((gdb_assert (SYMBOL_CLASS (symbol) == LOC_COMMON_BLOCK)), \
>    (symbol)->info.value.common_block)

Unfortunately these macros are used also for minimal_symbol which does not
have SYMBOL_CLASS.

This is another sanity check which can be implemented after -Wc++-compat gets
checked in.


Jan



More information about the Gdb-patches mailing list