[PATCH v9 21/29] record-btrace: provide xfer_partial target method

Metzger, Markus T markus.t.metzger@intel.com
Fri Dec 20 13:32:00 GMT 2013


> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Thursday, December 19, 2013 8:27 PM
> To: Metzger, Markus T
> Cc: jan.kratochvil@redhat.com; gdb-patches@sourceware.org
> Subject: Re: [PATCH v9 21/29] record-btrace: provide xfer_partial target
> method
> 
> On 12/19/2013 04:44 PM, Markus Metzger wrote:
> 
> Also,
> 
> > +  /* Filter out requests that don't make sense during replay.  */
> > +  if (!record_btrace_allow_memory_access &&
> record_btrace_is_replaying ())
> > +    {
> > +      switch (object)
> > +	{
> > +	case TARGET_OBJECT_MEMORY:
> > +	case TARGET_OBJECT_RAW_MEMORY:
> > +	case TARGET_OBJECT_STACK_MEMORY:
> > +	  {
> 
> I don't think you answered my comment about this in the previous
> series.  I think you can't ever see TARGET_OBJECT_RAW_MEMORY or
> TARGET_OBJECT_STACK_MEMORY here.

If we ever end up seeing them, they will simply be forwarded to the
target beneath without check.   I think it's safer to leave them in.
If you'd rather have them removed, I can do that, as well.

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052



More information about the Gdb-patches mailing list