[RFA] Allow Windows UNWIND_INFO version 2.
Tristan Gingold
gingold@adacore.com
Wed Dec 4 08:43:00 GMT 2013
On 03 Dec 2013, at 19:47, Pedro Alves <palves@redhat.com> wrote:
> On 12/03/2013 11:32 AM, Joel Brobecker wrote:
>> @@ -696,7 +697,17 @@ amd64_windows_frame_decode_insns (struct frame_info *this_frame,
>> return;
>>
>> end_insns = &insns[codes_count * 2];
>> - for (p = insns; p < end_insns; p += 2)
>> + p = insns;
>> +
>> + /* Skip opcodes 6 of version 2. This opcode is not documented. */
>> + if (PEX64_UWI_VERSION (ex_ui.Version_Flags) == 2)
>> + {
>> + for (; p < end_insns; p += 2)
>> + if (PEX64_UNWCODE_CODE (p[1]) != 6)
>> + break;
>> + }
>
> I'd consider merging with the existing loop, so that
> we print the opcodes when frame debug is enabled.
Not sure this is a good idea. You can use objdump -p if you want to view the opcodes.
But this opcode was also used in version 1, and in version 2 appears only before all other
opcodes.
Tristan.
More information about the Gdb-patches
mailing list