[RFA] Allow Windows UNWIND_INFO version 2.

[Pedro Alves]

On 12/03/2013 11:32 AM, Joel Brobecker wrote:
> @@ -696,7 +697,17 @@ amd64_windows_frame_decode_insns (struct frame_info *this_frame,
>  	return;
>  
>        end_insns = &insns[codes_count * 2];
> -      for (p = insns; p < end_insns; p += 2)
> +      p = insns;
> +
> +      /* Skip opcodes 6 of version 2.  This opcode is not documented.  */
> +      if (PEX64_UWI_VERSION (ex_ui.Version_Flags) == 2)
> +	{
> +	  for (; p < end_insns; p += 2)
> +	    if (PEX64_UNWCODE_CODE (p[1]) != 6)
> +	      break;
> +	}

I'd consider merging with the existing loop, so that
we print the opcodes when frame debug is enabled.

But anyway, this looks fine to me.

I clicked on "Did you find this helpful?  No" at:

  http://msdn.microsoft.com/en-us/library/ck9asaa9.aspx

and asked for info about v2 and opcode 6.  Not holding
my breath though.

-- 
Pedro Alves