[PATCH] Make "backtrace" doesn't print python stack if init python dir get fail
Hui Zhu
hui_zhu@mentor.com
Tue Dec 3 07:30:00 GMT 2013
On 12/03/13 00:05, Tom Tromey wrote:
>>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
>
> Hui> So if init python dir get fail, "backtrace" will print python
> Hui> stack. But GDB already output error when it start. I make a patch
> Hui> let it doesn't print python stack if init python dir get fail.
>
> Perhaps instead the setting of gdb_python_initialized should be moved to
> finish_python_initialization.
>
> Tom
>
Hi Tom,
I make a new patch according to your comments.
It setup gdb_python_initialized in finish_python_initialization.
I got a issue is ensure_python_env check gdb_python_initialized and throw error if it is 0.
So gdb_python_initialized to 0 will make some commands throw error when python dir has something error.
I removed this check in the patch.
This patch pass the regression test in x86_64 linux.
Please help me review it.
Thanks,
Hui
2013-12-03 Hui Zhu <hui@codesourcery.com>
* python/python.c (ensure_python_env): Remove check for
"gdb_python_initialized".
(_initialize_python): Remove setup of "gdb_python_initialized".
(finish_python_initialization): Add setup of
"gdb_python_initialized".
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -150,10 +150,6 @@ ensure_python_env (struct gdbarch *gdbar
{
struct python_env *env = xmalloc (sizeof *env);
- /* We should not ever enter Python unless initialized. */
- if (!gdb_python_initialized)
- error (_("Python not initialized"));
-
env->state = PyGILState_Ensure ();
env->gdbarch = python_gdbarch;
env->language = python_language;
@@ -1717,7 +1713,6 @@ message == an error message without a st
make_final_cleanup (finalize_python, NULL);
- gdb_python_initialized = 1;
return;
fail:
@@ -1807,6 +1802,9 @@ finish_python_initialization (void)
variable. */
do_cleanups (cleanup);
+
+ gdb_python_initialized = 1;
+
return;
fail:
More information about the Gdb-patches
mailing list