[OBV commit] Fix New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D 2013.08.18.00.00.15
Pierre Muller
pierre.muller@ics-cnrs.unistra.fr
Fri Aug 23 06:55:00 GMT 2013
> > Objet : New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D
> > 2013.08.18.00.00.15
> > > gdb/rs6000-nat.c:134: regression: hash: Do not use ' #...', instead
use
> > '#...'(some compilers only correctly parse a C preprocessor directive
when
> > '#' is the first character on the line)
> > gdb/rs6000-nat.c:134: #ifdef HAVE_PTRACE64
>
> In rs6000-nat.c, a new regression was introduced
> related to the hash rule:
>
> This rule says that:
> Do not use ` #...', instead use `#...'(some compilers only correctly parse
a
> C preprocessor directive when `#' is the first character on the line)
Fix committed as obvious,
Pierre Muller
as ARI maintainer
2013-08-23 Pierre Muller <muller@sourceware.org>
ARI fix: Push # directives to start of line.
* rs6000-nat.c (rs6000_ptrace32, rs6000_ptrace64): Rule applied.
Index: rs6000-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-nat.c,v
retrieving revision 1.129
diff -u -p -r1.129 rs6000-nat.c
--- rs6000-nat.c 7 Aug 2013 14:39:57 -0000 1.129
+++ rs6000-nat.c 23 Aug 2013 06:46:18 -0000
@@ -131,11 +131,11 @@ regmap (struct gdbarch *gdbarch, int reg
static int
rs6000_ptrace32 (int req, int id, int *addr, int data, int *buf)
{
- #ifdef HAVE_PTRACE64
+#ifdef HAVE_PTRACE64
int ret = ptrace64 (req, id, (long long) addr, data, buf);
- #else
+#else
int ret = ptrace (req, id, (int *)addr, data, buf);
- #endif
+#endif
#if 0
printf ("rs6000_ptrace32 (%d, %d, 0x%x, %08x, 0x%x) = 0x%x\n",
req, id, (unsigned int)addr, data, (unsigned int)buf, ret);
@@ -149,11 +149,11 @@ static int
rs6000_ptrace64 (int req, int id, long long addr, int data, void *buf)
{
#ifdef ARCH3264
- #ifdef HAVE_PTRACE64
+# ifdef HAVE_PTRACE64
int ret = ptrace64 (req, id, addr, data, buf);
- #else
+# else
int ret = ptracex (req, id, addr, data, buf);
- #endif
+# endif
#else
int ret = 0;
#endif
More information about the Gdb-patches
mailing list