[PATCH 1/3] Fix ppc64 single step over atomic sequence testcase
Anton Blanchard
anton@samba.org
Fri Aug 2 13:45:00 GMT 2013
Hi Uli,
> I think it might be best to just get rid of those .include statements;
> depending on an .inc file from another directory seems surprising.
>
> It seems you only need it for the gdbasm_declare macro; since this
> file is ppc64 specific anyway, why don't you just hard-code the
> .opd generation in this source file?
Considering the issues we have had with getting the correct include
paths passed into the assembler, I tend to agree. It only saves a couple
of lines.
> Also, the assembler source file probably ought to keep the
> copyright header. A comment why this test needs to use
> assembler source also would be good.
Thanks, will incorporate that into the next spin.
Anton
More information about the Gdb-patches
mailing list