[RFA] Thread exit messages on MS-Windows

Joel Brobecker brobecker@adacore.com
Tue Apr 30 11:51:00 GMT 2013


> I know what to do with Corinna's comment, but not what to decide about
> announcing the death of the main thread.  Do you have an opinion?

No strong opinion, but I share your preference.

> My reading of the code is that you already see that in linux-native
> debugging, see linux-nat.c.

'must have missed it... sorry :).

> > One tiny nitpick, very possibly influenced by personal preferences,
> > so feel free to ignore...  I think that the code would be faster
> > to read if the added parameter was moved to the next line. That way,
> > all parameters in call to windows_delete_thread would have the same
> > indentation level.
> 
> I'm surprised, but I don't mind, and will do that, too.

Then don't. It's such a small comment that it's not worth changing.

-- 
Joel



More information about the Gdb-patches mailing list