[patch][python] 3 of 5 - Frame filter CLI/misc code changes.

Tom Tromey tromey@redhat.com
Fri Apr 26 11:35:00 GMT 2013


Phil> 	* Makefile.in: Add py-framefiler build changes.

Typo in the file name.
It's more usual to list the variables you updated and also the new
rule.

Phil> 	* data-directory/Makefile.in: Ditto

I don't think "ditto" is correct here.

Phil> +  int result = 0;

enum type.

Phil> +      int flags = PRINT_LEVEL | PRINT_FRAME_INFO | PRINT_ARGS;
Phil> +      enum py_frame_args arg_type;
Phil>        if (show_locals)
Phil> +	flags |= PRINT_LOCALS;

Blank line between declarations and code here.

Tom



More information about the Gdb-patches mailing list