[patch 1/2+7.6] /proc/PID/smaps: filename fix

[Pedro Alves]

On 03/29/2013 08:27 PM, Jan Kratochvil wrote:
> On Fri, 29 Mar 2013 21:24:38 +0100, Andreas Schwab wrote:
>> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>>
>>> currently GDB complains:
>>> 	warning: Error parsing {s,}maps file '[heap]'
>>> 	warning: Error parsing {s,}maps file '/usr/lib64/libc-2.17.so'
>>>
>>> which is sure incorrect, it should have been:
>>> 	warning: Error parsing {s,}maps file '/proc/30100/smaps'
>>> 	warning: Error parsing {s,}maps file '/proc/30100/smaps'
>>
>> Which mean you'll no longer know what's wrong with it.

The current warning doesn't actually show what failed to parse.
We'd need to print the line for that.

> 
> I believe the second output was originally intended, this is what this patch
> tries to fix.

I agree.

> 
> It may not be perfect but it only tries to suggest what is that "{s,}maps
> file".  I did not write this code (although reviewed it IIRC).


-- 
Pedro Alves