[patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)

Doug Evans dje@google.com
Mon Sep 17 15:40:00 GMT 2012


On Mon, Sep 17, 2012 at 8:29 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> gdb/
> 2012-09-17  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>         Fix internal error on canonicalization of clang types.
>         * cp-name-parser.y (exp): Use "sizeof ".
>
>
> diff --git a/gdb/cp-name-parser.y b/gdb/cp-name-parser.y
> index 6767fa5..c57ce64 100644
> --- a/gdb/cp-name-parser.y
> +++ b/gdb/cp-name-parser.y
> @@ -1183,7 +1183,7 @@ exp       :       FLOAT
>         ;
>
>  exp    :       SIZEOF '(' type ')'     %prec UNARY
> -               { $$ = d_unary ("sizeof", $3); }
> +               { $$ = d_unary ("sizeof ", $3); }
>         ;
>
>  /* C++.  */

I had to look hard to see the change here.
Comment explaining "why things are they way they are" is required IMO.
[I'm assuming the above change is in fact TRTTD.]



More information about the Gdb-patches mailing list