mips-rtems4.11 sim undefined error
Mike Frysinger
vapier@gentoo.org
Tue Sep 4 21:10:00 GMT 2012
On Tue, Sep 4, 2012 at 4:16 PM, Joel Sherrill wrote:
> On 09/04/2012 02:09 PM, Mike Frysinger wrote:
>> On Tue, Sep 4, 2012 at 12:57 PM, Joel Sherrill wrote:
>>>
>>> --- configure.ac 4 Jan 2012 08:28:20 -0000 1.18
>>> +++ configure.ac 4 Sep 2012 15:45:13 -0000
>>> @@ -413,7 +413,7 @@
>>> SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>> ;;
>>> *)
>>> - mips_extra_objs=""
>>> + mips_extra_objs="dv-sockser.o"
>>> ;;
>>> esac
>>
>> considering mips_extra_objs is now the same value for all targets, i
>> would pull it out of the case statement and move it down below
>>
> How about this?
>
>
> Index: configure.ac
> ===================================================================
> RCS file: /cvs/src/src/sim/mips/configure.ac,v
> retrieving revision 1.18
> diff -u -r1.18 configure.ac
> --- configure.ac 4 Jan 2012 08:28:20 -0000 1.18
> +++ configure.ac 4 Sep 2012 20:15:37 -0000
> @@ -409,13 +409,12 @@
> mips*tx39*)
> hw_enabled=yes
> hw_extra_devices="tx3904cpu tx3904irc tx3904tmr tx3904sio"
> - mips_extra_objs="dv-sockser.o"
>
> SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
> ;;
> *)
> - mips_extra_objs=""
> ;;
> esac
> +mips_extra_objs="dv-sockser.o"
> SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
> AC_SUBST(mips_extra_objs)
i'd move it down one line more to just above AC_SUBST :)
feel free to commit w/that minor tweak
-mike
More information about the Gdb-patches
mailing list